"[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory"

Fixed golem breakage by temporarily copying dartaotruntime to dart_precompiled_runtime

This reverts commit 75e6a74.

TEST=ci

Original change's description:
> Revert "[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory"
>
> This reverts commit 1b331d0.
>
> Reason for revert: golem builds are failing
>
> Original change's description:
> > [SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory
> >
> > TEST=ci
> >

Change-Id: Id0f383eabb496c06c0acebc639c8e3b056ba82d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393781
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>

Author: a-siva

BUILD.gn

@@ -86,7 +86,7 @@ group("run_ffi_unit_tests") {
 group("runtime_precompiled") {
   import("runtime/runtime_args.gni")
   deps = [
-    "runtime/bin:dart_precompiled_runtime",
+    "runtime/bin:dartaotruntime",
     "runtime/bin:gen_snapshot",
     "runtime/bin:gen_snapshot($host_toolchain)",
     "runtime/bin:process_test",
@@ -110,7 +110,15 @@ group("create_platform_sdk") {
 }
 
 group("dart2js") {
-  deps = [ "utils/compiler:dart2js" ]
+  import("runtime/runtime_args.gni")
+  if (dart_target_arch != "ia32" && dart_target_arch != "x86") {
+    deps = [
+      ":runtime_precompiled",
+      "utils/compiler:dart2js_sdk_aot",
+    ]
+  } else {
+    deps = [ "utils/compiler:dart2js" ]
+  }
 }
 
 group("dart2wasm_platform") {
@@ -148,7 +156,19 @@ group("dartanalyzer") {
 }
 
 group("ddc") {
-  deps = [ "utils/ddc:dartdevc" ]
+  import("runtime/runtime_args.gni")
+  if (dart_target_arch != "ia32" && dart_target_arch != "x86") {
+    deps = [
+      ":runtime_precompiled",
+      "utils/bazel:kernel_worker_aot",
+      "utils/ddc:dartdevc_aot",
+    ]
+  } else {
+    deps = [
+      "utils/bazel:kernel_worker",
+      "utils/ddc:dartdevc",
+    ]
+  }
 }
 
 group("analysis_server") {
@@ -367,7 +387,7 @@ if (is_fuchsia) {
 
   test_binaries = [
     "dart",
-    "dart_precompiled_runtime",
+    "dartaotruntime",
     "run_vm_tests",
   ]
 

benchmarks/NativeCall/native/native_functions.c

@@ -7,7 +7,7 @@
 #include <string.h>
 
 // TODO(dartbug.com/40579): This requires static linking to either link
-// dart.exe or dart_precompiled_runtime.exe on Windows.
+// dart.exe or dartaotruntime.exe on Windows.
 // The sample currently fails on Windows in AOT mode.
 #include "include/dart_api.h"
 

docs/Kernel-developer-notes.md

@@ -28,7 +28,7 @@ Run end-to-end tests using dartk + VM:
 
 Optionally (this is slow) run end-to-end tests using AOT:
 ```
-./tools/build.py dart_precompiled_runtime
+./tools/build.py runtime_precompiled
 ./tools/test.py -cdartkp -rdart_precompiled language co19
 ```
 

pkg/dart2wasm/tool/compile_benchmark

@@ -35,7 +35,7 @@ BIN_DIR="$OUT_DIR/$DART_CONFIGURATION"
 
 BINARYEN="$BIN_DIR/wasm-opt"
 DART="$BIN_DIR/dart"
-DART_AOT_RUNTIME="$BIN_DIR/dart_precompiled_runtime"
+DART_AOT_RUNTIME="$BIN_DIR/dartaotruntime"
 LIBRARIES_JSON_ARG="--libraries-spec=$SDK_DIR/sdk/lib/libraries.json"
 
 function find_flags {

pkg/dartdev/lib/src/sdk.dart

@@ -54,8 +54,8 @@ class Sdk {
       ? path.absolute(
           sdkPath,
           Platform.isWindows
-              ? 'dart_precompiled_runtime_product.exe'
-              : 'dart_precompiled_runtime_product',
+              ? 'dartaotruntime_product.exe'
+              : 'dartaotruntime_product',
         )
       : path.absolute(
           sdkPath,

pkg/dev_compiler/test/worker/worker_test.dart

@@ -25,17 +25,19 @@ void main() {
   var dartAotRuntime = p.absolute(
       sdkPath,
       Platform.isWindows
-          ? 'dart_precompiled_runtime_product.exe'
-          : 'dart_precompiled_runtime_product');
+          ? 'dartaotruntime_product.exe'
+          : 'dartaotruntime_product');
+  var snapshotName = _resolvePath('gen/dartdevc_aot_product.dart.snapshot');
   if (!File(dartAotRuntime).existsSync()) {
     dartAotRuntime = p.absolute(
         sdkPath,
         Platform.isWindows
-            ? 'dart_precompiled_runtime.exe'
-            : 'dart_precompiled_runtime');
+            ? 'dartaotruntime_product.exe'
+            : 'dartaotruntime_product');
+    snapshotName = _resolvePath('gen/dartdevc_aot.dart.snapshot');
   }
   final executableArgs = <String>[
-    _resolvePath('gen/dartdevc_aot.dart.snapshot'),
+    snapshotName,
     '--sound-null-safety',
     '--dart-sdk-summary',
     _resolvePath('ddc_outline.dill'),

pkg/dynamic_modules/test/runner/util.dart

@@ -86,9 +86,8 @@ Uri genSnapshotBin =
     buildRootUri.resolve(useProduct ? 'gen_snapshot_product' : 'gen_snapshot');
 Uri dart2bytecodeSnapshot =
     buildRootUri.resolve('gen/dart2bytecode.dart.snapshot');
-Uri aotRuntimeBin = buildRootUri.resolve(useProduct
-    ? 'dart_precompiled_runtime_product'
-    : 'dart_precompiled_runtime');
+Uri aotRuntimeBin = buildRootUri
+    .resolve(useProduct ? 'dartaotruntime_product' : 'dartaotruntime');
 Uri vmPlatformDill = buildRootUri.resolve('vm_platform_strong.dill');
 
 // Encodes test results in the format expected by Dart's CI infrastructure.

pkg/front_end/lib/src/linux_and_intel_specific_perf.dart

@@ -41,7 +41,7 @@ int _perfPid = -1;
 /// You might also want the dartaotruntime to include debug symbols:
 ///
 /// ```
-/// cp out/ReleaseX64/dart_precompiled_runtime_product \
+/// cp out/ReleaseX64/dartaotruntime_product \
 ///   out/ReleaseX64/dart-sdk/bin/dartaotruntime
 /// ```
 ///

pkg/smith/lib/configuration.dart

@@ -251,7 +251,7 @@ class Configuration {
           .pathSegments
           .lastWhere((e) => e.isNotEmpty);
       final executableNoExtension = executableName.split('.').first;
-      if (executableNoExtension == 'dart_precompiled_runtime') {
+      if (executableNoExtension == 'dartaotruntime') {
         runtime = Runtime.dartPrecompiled;
       } else if (executableNoExtension == 'dart') {
         runtime = Runtime.vm;

pkg/test_runner/lib/src/build_configurations.dart

@@ -80,7 +80,7 @@ List<String> _selectBuildTargets(Configuration inner) {
   final compiler = inner.compiler;
   const targetsForCompilers = {
     Compiler.dartk: ['runtime'],
-    Compiler.dartkp: ['runtime', 'dart_precompiled_runtime'],
+    Compiler.dartkp: ['runtime', 'runtime_precompiled'],
     Compiler.appJitk: ['runtime'],
     Compiler.fasta: ['create_sdk', 'ddc_stable_test', 'kernel_platform_files'],
     Compiler.ddc: ['ddc_stable_test'],