Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve key-based "navigate to resource..." action #3433

Closed
jmesserly opened this issue Jun 7, 2012 · 7 comments
Closed

Improve key-based "navigate to resource..." action #3433

jmesserly opened this issue Jun 7, 2012 · 7 comments
Assignees
@pq
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Milestone
Oldschool-Later

Comments

@jmesserly
Copy link

One of my favorite features of Textmate and Sublime Text (and even Visual Studio) is the ability to easily jump to a file by using shortcut key + typing part of the file name. I can almost get this in the Dart Editor using the Ctrl+3 search box. However, I've run into a few issues:

The file is missing semi-randomly. Some files that are clearly in my file tree, and definitely being analyzed, don't show up. I'm not sure how I get it into this state. It seems like if you find a file, and then (without leaving the search box) shift+home and type another file name, sometimes it doesn't show up. However, leaving the search box and coming back will usually find it.

Second issue: if there's only a file result, I wish it would go to the file instead of defaulting to a search when I hit enter. I end up doing "Down arrow, down arrow, enter". Or maybe a different key should bring up a file search? In Sublime Text it's Ctrl+P, in Visual Studio you type "of <filename>" where of stands for open file (http://www.alteridem.net/2007/09/11/quickly-findopen-a-file-in-visual-studio/). But it lets you disambiguate your intent when searching.
@pq
Copy link
Member

pq commented Jun 7, 2012

Thanks for the feedback John!

  1. Flaky search results: I'll do some digging into this. If you uncover any clues, let me know!
  2. I hear you. Defaulting to anything is a risk. It can't be what everyone expects. I've thought a bit about a simple query language to better communicate intent and scope search but I didn't know about the visual studio precedent. Thanks! An alternative, already requested, would be to provide a dedicated file navigation chooser a la the eclipse open resource dialog (http://www.flickr.com/photos/choonkeat/427604995/). Ideally though, it'd be great if the searchbox where the single place to initiate search so I'd like to push a little more on that before simply adding more UI surface area.
    Set owner to @pq.
    Added this to the M1 milestone.
    Added Usability, Accepted labels.

@pq
Copy link
Member

pq commented Jun 14, 2012

Confirmed that shift-HOME breaks filematching... Looking at this now.

Added Started label.

@pq
Copy link
Member

pq commented Jul 29, 2012

The Shift-HOME issue should now be fixed.

Converting this issue to an enhancement request to cover streamlining "open resource" workflow.

Removed this from the M1 milestone.
Added this to the Later milestone.
Removed Type-Defect label.
Added Type-Enhancement, Accepted labels.
Changed the title to: "Improve key-based "navigate to resource..." action".

@DartBot
Copy link

DartBot commented Apr 7, 2013

This comment was originally written by amouravski@google.com

Added Editor-Usability label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@sethladd
Copy link
Contributor

Added NotPlanned label.

@clayberg
Copy link

Added this to the 1.6 milestone.

@jmesserly jmesserly added Type-Enhancement closed-not-planned Closed as we don't intend to take action on the reported issue labels Aug 13, 2014
@jmesserly jmesserly added this to the Oldschool-Later milestone Aug 13, 2014
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Jun 8, 2023
@devoncarew
[deps] rev dartdoc, http_parser, leak_tracker, path, pool, term_glyph…
8357b8a 
…, typed_data

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/449478c..2a39574):
  2a395741  2023-06-07  Sam Rawlins  Seal mustachio nodes (#3433)
  d5bb24b2  2023-06-07  Sam Rawlins  Convert Tuples to Records and split a helper out from findCanonicalModelElementFor (#3432)

http_parser (https://github.com/dart-lang/http_parser/compare/1ef3e56..19466c0):
  19466c0  2023-06-07  Kevin Moore  Require Dart 3.0, update lints (#74)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/f17da61..fc45bec):
  fc45bec  2023-06-07  Polina Cherkasova  Break the leak tracker code to packages. (#80)

path (https://github.com/dart-lang/path/compare/f8d15c2..592505f):
  592505f  2023-06-07  Kevin Moore  Require Dart 3.0, update lints (#146)

pool (https://github.com/dart-lang/pool/compare/a10a0f9..c6b1b2c):
  c6b1b2c  2023-06-07  Kevin Moore  Require Dart 3.0, update lints (#71)

term_glyph (https://github.com/dart-lang/term_glyph/compare/9d8956f..4daa34e):
  4daa34e  2023-06-07  Kevin Moore  Require Dart 3.0, update lints (#39)

typed_data (https://github.com/dart-lang/typed_data/compare/693f48e..8d29573):
  8d29573  2023-06-07  Kevin Moore  Require Dart 3.0, update lints (#67)

Change-Id: I11fe765858ba970f13a2051abee34abf910f4698
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308161
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
Oldschool-Later
Development

No branches or pull requests
7 participants
@sethladd @kevmoo @pq @jmesserly @kasperl @clayberg @DartBot