Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for protocol buffers #951

Closed
DartBot opened this issue Dec 22, 2011 · 19 comments
Closed

Support for protocol buffers #951

DartBot opened this issue Dec 22, 2011 · 19 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Dec 22, 2011

This issue was originally filed by domi...@google.com

JSON is good, but weakly typed. Protocol buffers are more Dartish and it would be great if there was an SDK to support them.
@DartBot
Copy link
Author

DartBot commented Dec 22, 2011

This comment was originally written by drfibonacci@google.com

Removed Type-Defect label.
Added Type-Enhancement, Area-Library, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Aug 14, 2012

This comment was originally written by @sethladd

Here's the CL: https://chromiumcodereview.appspot.com/10595002/

Doesn't look like it was ever merged.

@DartBot
Copy link
Author

DartBot commented Aug 22, 2012

This comment was originally written by tiag...@gmail.com

Any chance to get this merged or something similar implemented in a near future?

@DartBot
Copy link
Author

DartBot commented Oct 9, 2012

This comment was originally written by @Scorpiion

Any news or estimates on when support for protocol buffers will be available in Dart? Could someone provide a link to where the latest code could be found? I can't find any branch that has "lib/protobuf" over at http://code.google.com/p/dart/source/browse

Maybe downloading these two patches is the way to go?
https://chromiumcodereview.appspot.com/user/Dan%20Rice

@DartBot
Copy link
Author

DartBot commented Dec 17, 2012

This comment was originally written by antonm@google.com

Set owner to antonm@google.com.
Added Started label.

@DartBot
Copy link
Author

DartBot commented Jan 8, 2013

This comment was originally written by denys.y.mete...@gmail.com

Hello Gentleman,
 
 I think that protocol buffers are really important for Dart to be a top technology for HTML5 development.
 Due to recent braking changes with Dart (getters/function/intrfaces/hashable etc..) code was originally submitted by Dan does not work anymore. I have ported code to use current Dart (Milestone2) language specifications.
 Sorry attached .zip as I do not have a repository checkouted to create diff. Hope it will be helpful, when somebody will add ProtocolBuffers into dart-sdk.
 

Attachment:
protobuf.tar.gz (80 KB)

@DartBot
Copy link
Author

DartBot commented Jan 18, 2013

This comment was originally written by scottishph...@gmail.com

I have updated that again as a dart package (not yet tested, just got it so that it compiles again) https://github.com/ucam-cl-dtg/dart-protobuf

@DartBot
Copy link
Author

DartBot commented Jan 18, 2013

This comment was originally written by denys.y.metels...@gmail.com

Hello, i though, there is no interest in protocolbuffers for dart so i did not bother to submit last update. but archive, i send earlier still had issues in runtime libs, not they are fixed. I been testing it works very well for me simple and complex types. (haven't touched actual test cases), so if anybody, just need something that works, it is. I promise I will be submitting the .patch files from now on.

Attachment:
protobuf_2.tar.gz (80 KB)

@DartBot
Copy link
Author

DartBot commented Jan 19, 2013

This comment was originally written by @financecoding

Nice

@DartBot
Copy link
Author

DartBot commented Jan 19, 2013

This comment was originally written by denys.y.mete...@gmail.com

how does your comment, is relevant to the issue. ?

@DartBot
Copy link
Author

DartBot commented Jan 21, 2013

This comment was originally written by scottishph...@gmail.com

Comment #­10 was completely irrelevant to the issue. It really should not have been made.

Thank you for supplying an update, I will take a look at it in a week or two.

@DartBot
Copy link
Author

DartBot commented Jan 21, 2013

This comment was originally written by Denys.Metelsky...@petrodaq.com

excellent, I will use your github repository, if I will make any improvement to the code.

@DartBot
Copy link
Author

DartBot commented Jan 29, 2013

This comment was originally written by scottishphoen...@gmail.com

So having got the code to compile and run I have run into an issue which someone else has reported at ucam-cl-dtg/dart-protobuf#1 which I don't know how to resolve as it is some asynchronous code with a stacktrace that does not mention any of the protobuf code. Help much appreciated.

@DartBot
Copy link
Author

DartBot commented Jan 30, 2013

This comment was originally written by denys.y.mete...@gmail.com

 Daniel, I tried to use your code from github repo.

But I run into troubles with compatibility with latest Dart, so I reported the error.

I fixed problems in my working copy, (I am able to generate .pb.dart files, still need to test runtime stuff).

 But I couldn't understand why We get ( NoSuchMethodError : method not found: 'call' ) in your repository, so I going to run diff against your code, and sent it to you change set, maybe it will aid you to locate a problem.

@DartBot
Copy link
Author

DartBot commented Jan 31, 2013

This comment was originally written by scottishphoeni...@gmail.com

Slightly confused. Where have you reported the error? If you could send me a diff or a pull request that would be great.

@DartBot
Copy link
Author

DartBot commented Feb 1, 2013

This comment was originally written by denys.y.metels...@gmail.com

sorry for confusion.

i talking about issue this error i reported
ucam-cl-dtg/dart-protobuf#1

(it is hard to find what fail inside isolates, without stake-trace, specially as API changes every week) :

Unfortunately I haven't done merging my code with your's yet. So I can not make a diff.

If you willing to do it yourself - I created repository of my working copy (plugin is working as well as runtime) , as I thinking to brake style of original library:
https://github.com/eflauzo/ProtocolBuffers-Dart.git

I think building and parsing messages is a bit ugly.

I will try to keep up with Dart changes, just to have it usable

@DartBot
Copy link
Author

DartBot commented May 18, 2013

This comment was originally written by george.moschoviti...@gmail.com

I would really love to use this with Google Cloud Datastore.

@DartBot
Copy link
Author

DartBot commented Jul 8, 2013

This comment was originally written by me...@davebettin.com

Any updates on releasing a protobuf library? Thanks!

@DartBot
Copy link
Author

DartBot commented Jul 8, 2013

This comment was originally written by antonm@google.com

Yes, we should be able to push something very soon.

@DartBot DartBot added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Jul 8, 2013
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
dart-bot pushed a commit that referenced this issue Oct 12, 2020
@athomas
[co19] Roll co19 to 2111e4f933e262e8b127bbbae766609463364a67
5907769 
2020-10-12 sgrekhov@unipro.ru #951. Changed error expectation to not to fail on tryjobs
2020-10-12 sgrekhov@unipro.ru #912. Added tests for external variable declaration

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I8e27b4a1605a9503056c3d18e0a8cd4b2d7b3383
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166848
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
dart-bot pushed a commit that referenced this issue Nov 19, 2020
@athomas
[co19] Roll co19 to 1653a8f5242599b7b8d40b9f1466f717556626d0
dcafee7 
2020-11-19 sgrekhov@unipro.ru #926.Add Platform.executableArguments to Process.run() command to not to fail on --enable-assert configuration
2020-11-19 sgrekhov@unipro.ru #926.Add Platform.executableArguments to Process.run() command to not to fail on --enable-assert configuration
2020-11-18 sgrekhov@unipro.ru Fixes #966. Move certificates to RawSecureServerSocket directory
2020-11-18 sgrekhov@unipro.ru #926. Fixed test that fail on precompiled environment in a strong mode
2020-11-17 sgrekhov@unipro.ru Fixes #951. Remove excessive @static-warning
2020-11-17 irina.arkhipets@gmail.com Fixes #946: LanguageFeatures/Instantiate-to-bound/nonfunction_typedef tests updated according to the SDK changes, missing tests added.
2020-11-17 sgrekhov@unipro.ru #932. Some HttpRequest tests fixed to work well with cross origin requests
2020-11-16 sgrekhov@unipro.ru Process kill test fixed to work on different platforms
2020-11-16 sgrekhov@unipro.ru External variable test that expects compile time error on dart2js added
2020-11-13 sgrekhov@unipro.ru Fixes #926. Remove "--enable-experiment=non-nullable" option from script that runs another process
2020-11-12 sgrekhov@unipro.ru #926. File lock checking tests rewritten to not to fail on precompiled environment. Second part
2020-11-12 irina.arkhipets@gmail.com Fixes #602: Missing issue tags added.
2020-11-11 sgrekhov@unipro.ru #926. File lock checking tests rewritten to not to fail on precompiled environment
2020-11-11 sgrekhov@unipro.ru Issue numbers added
2020-11-11 irina.arkhipets@gmail.com Fixes #963: test expected result corrected, test template for all generic typedefs updated.
2020-11-10 sgrekhov@unipro.ru #926. ProcessSignal tests rewritten to not to fail on precompiled environment
2020-11-10 sgrekhov@unipro.ru #926. Process tests rewritten to not to fail on precompiled environment
2020-11-10 sgrekhov@unipro.ru #961. Process tests rewritten to not to use process_test tool
2020-11-10 irina.arkhipets@gmail.com Fixes #602: Missing Issue tag added.
2020-11-10 sgrekhov@unipro.ru Fixes #960. Null safety execution modes renamed and mentions of obsolete checked mode removed
2020-11-10 sgrekhov@unipro.ru Remove wrong error expectations
2020-11-09 sgrekhov@unipro.ru Fixes #962. Change CFE error messages expectations
2020-11-08 irina.arkhipets@gmail.com Fixes #602: New tests for least and greatest closures added.

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I7aff067ec96f762490de15daa20c40dff2b0ae96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172940
Reviewed-by: William Hesse <whesse@google.com>
copybara-service bot pushed a commit that referenced this issue Jun 1, 2023
@devoncarew
[deps] rev args, bazel_worker, dartdoc, http, leak_tracker, mockito, …
7b3305e 
…native, protobuf, pub_semver, shelf, stack_trace, tools, vector_math, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/f0f6cd2..a9543c0):
  a9543c0  2023-05-31  Devon Carew  switch to using package:dart_flutter_team_lints (#247)
  36407ea  2023-05-31  Devon Carew  adjust the validation of mandatory options (#246)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/d9b389f..c14a268):
  c14a268  2023-05-31  Kevin Moore  Bump lints, regenerate proto file, fix script (#74)

dartdoc (https://github.com/dart-lang/dartdoc/compare/950898f..39fe1a8):
  39fe1a8a  2023-05-31  Parker Lougheed  Update highlight.js to 11.8.0 for Dart 3 syntax highlighting (#3416)
  4574e819  2023-05-30  Sam Rawlins  Convert kind to an enum (#3426)

http (https://github.com/dart-lang/http/compare/18a43a2..8834aec):
  8834aec  2023-05-31  Brian Quinlan  Update readme and prepare for a new release (#954)
  aca7f0e  2023-05-31  dependabot[bot]  Bump futureware-tech/simulator-action from 1 to 2 (#936)
  7a238a9  2023-05-31  dependabot[bot]  Bump actions/labeler from 4.0.2 to 4.0.4 (#952)
  4c0eb48  2023-05-30  Brian Quinlan  Prepare to publish cupertino_http 1.0.0 (#951)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/7f2cab3..cbbdeca):
  cbbdeca  2023-05-31  Polina Cherkasova  Improve getting retaining path. (#69)

mockito (https://github.com/dart-lang/mockito/compare/40fe2ca..924f65c):
  924f65c  2023-06-01  Ilya Yanok  Add support for records

native (https://github.com/dart-lang/native/compare/76bc55e..c851e69):
  c851e69  2023-06-01  dependabot[bot]  Bump nttld/setup-ndk (#57)
  0df0cad  2023-06-01  dependabot[bot]  Bump actions/labeler from 4.0.3 to 4.0.4 (#58)
  c30faa2  2023-05-31  Daco Harkes  [c_compiler] test install_name_tool behavior (#56)
  45ef2e7  2023-05-31  Daco Harkes  [c_compiler] Support setting the install name of dylibs (#55)

protobuf (https://github.com/dart-lang/protobuf/compare/346a72d..da6953c):
  da6953c  2023-05-31  Kevin Moore  Update to latest lints and Dart SDK (#828)

pub_semver (https://github.com/dart-lang/pub_semver/compare/c034352..3930557):
  3930557  2023-05-31  Kevin Moore  Bump lints, require Dart 3.0 (#89)

shelf (https://github.com/dart-lang/shelf/compare/a404b6a..ce379aa):
  ce379aa  2023-06-01  dependabot[bot]  Bump actions/labeler from 4.0.3 to 4.0.4 (#363)

stack_trace (https://github.com/dart-lang/stack_trace/compare/86f7e30..8b2046e):
  8b2046e  2023-05-31  Devon Carew  blast_repo fixes (#134)

tools (https://github.com/dart-lang/tools/compare/d723a55..389925f):
  389925f  2023-06-01  Elias Yishak  Utility function added to check permissions on directory (#95)
  a436fee  2023-05-31  Elias Yishak  Asserts added to check all relevant GA4 limitations (#96)

vector_math (https://github.com/google/vector_math.dart/compare/cd87f57..a3aca09):
  a3aca09  2023-05-31  Lukas Klingsbo  fix: Revert negation change for Vector2 (#296)

webdev (https://github.com/dart-lang/webdev/compare/d442fa8..f565d7f):
  f565d7f1  2023-05-31  Anna Gringauze  Disable flaky test on windows (#2127)
  6eed300e  2023-05-31  Anna Gringauze  Cleanup expression evalaluation tests (#2125)

Change-Id: Ia568db23bbc923f764cdf323e249175b609d57ee
Tested: affected files are regenerated test goldens
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306903
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevmoo @DartBot