-
Notifications
You must be signed in to change notification settings - Fork 44
Initial structure for shared website styles #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
37aea4e
Experiment with a structure for shared styles
parlough 3cb6eaf
Add template for a README
parlough 1fc526d
Merge branch 'main' into feat/dash-design-package
parlough 3858a28
Separate typography from colors
parlough 384c8c1
Run the build test with all deprecations enabled
parlough 3b5060f
Switch to using dark-theme on body for now
parlough 029a2f6
Adjust naming scheme
parlough f532780
Start with current pub text colors
parlough File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| Copyright 2024, the Dart project authors. | ||
|
|
||
| Redistribution and use in source and binary forms, with or without | ||
| modification, are permitted provided that the following conditions are | ||
| met: | ||
|
|
||
| * Redistributions of source code must retain the above copyright | ||
| notice, this list of conditions and the following disclaimer. | ||
| * Redistributions in binary form must reproduce the above | ||
| copyright notice, this list of conditions and the following | ||
| disclaimer in the documentation and/or other materials provided | ||
| with the distribution. | ||
| * Neither the name of Google LLC nor the names of its | ||
| contributors may be used to endorse or promote products derived | ||
| from this software without specific prior written permission. | ||
|
|
||
| THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
| A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
| OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| ## Shared styles for Dart and Flutter websites | ||
|
|
||
| > [!CAUTION] | ||
| > This package and the styles it contains are in progress, | ||
| > and are subject to breakages or removal at any point. | ||
|
|
||
| ### Usage | ||
|
|
||
| To be determined. | ||
|
|
||
| ### Contributing | ||
|
|
||
| Contribution information and guidelines to be added. | ||
|
|
||
| ### Intended clients | ||
|
|
||
| - dart.dev | ||
| - docs.flutter.dev | ||
| - pub.dev | ||
| - api.dart.dev | ||
| - api.flutter.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| include: package:analysis_defaults/analysis.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// styles.scss: | ||
parlough marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| /// | ||
| /// Incorporates all styles and CSS custom properties (variables) | ||
| /// from the dash_design package. | ||
| /// | ||
| /// Most variables are added at the `:root` (the `html` element), | ||
| /// but dark mode variable overrides are added to the `body` element if | ||
| /// the class `dark-theme` is added to it. | ||
|
|
||
| @use 'styles/variables'; | ||
|
|
||
| $google-site: false !default; | ||
|
|
||
| :root { | ||
| @include variables.typography; | ||
| @include variables.shared-colors; | ||
|
|
||
| @include variables.light-theme; | ||
|
|
||
| @if $google-site { | ||
| @include variables.google-overrides; | ||
| } | ||
| } | ||
|
|
||
| body { | ||
| &.dark-theme { | ||
| @include variables.dark-theme; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// styles/variables.scss: | ||
| /// | ||
| /// Mixins that can be included to load CSS custom properties (variables) | ||
| /// into any desired scope. | ||
|
|
||
| /// Shared typography CSS variables. | ||
| @mixin typography { | ||
| /// Used for body text and smaller UI elements, like labels. | ||
| --dash-default-fontFamily: 'Roboto', sans-serif; | ||
|
|
||
| /// Used for headlines, titles, and larger UI elements. | ||
| --dash-display-fontFamily: 'Roboto', sans-serif; | ||
|
|
||
| /// Used for monospace text, such as code blocks. | ||
| --dash-mono-fontFamily: 'Roboto Mono', 'Source Code Pro', 'Cascadia Mono', 'JetBrains Mono', monospace; | ||
|
|
||
| /// Used for icons, such as the magnifying glass for search. | ||
| --dash-symbol-fontFamily: 'Material Symbols', 'Material Symbols Outlined'; | ||
| } | ||
|
|
||
| /// Color-related, theme-agnostic CSS variables. | ||
| @mixin shared-colors { | ||
|
|
||
| } | ||
|
|
||
| /// Light-theme specific CSS variables. | ||
| @mixin light-theme { | ||
| /// The default text color, used for body text. | ||
| --dash-surface-fgColor: #4a4a4a; | ||
| } | ||
|
|
||
| /// Dark-theme specific CSS variables. | ||
| @mixin dark-theme { | ||
| --dash-surface-fgColor: #dcdcdc; | ||
| } | ||
|
|
||
| /// CSS variables that specify values that can only be used by Google sites, | ||
| /// such as enabling the Google Sans font families. | ||
| /// | ||
| /// These overrides should be included after all other variables are defined. | ||
| @mixin google-overrides { | ||
| // Non-Google sites, such as self-hosted API docs, | ||
| // can't use Google Sans or Google Symbols. | ||
| --dash-default-fontFamily: 'Google Sans Text', 'Google Sans', 'Roboto', sans-serif; | ||
| --dash-display-fontFamily: 'Google Sans', 'Google Sans Text', 'Roboto', sans-serif; | ||
| --dash-mono-fontFamily: 'Google Sans Mono', 'Roboto Mono', 'Source Code Pro', 'Cascadia Mono', 'JetBrains Mono', monospace; | ||
| --dash-symbol-fontFamily: 'Google Symbols', 'Material Symbols', 'Material Symbols Outlined'; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| sdk: | ||
| - pubspec | ||
| - dev | ||
|
|
||
| stages: | ||
| - analyzer_and_format: | ||
| - group: | ||
| - format | ||
| - analyze: --fatal-infos . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| name: dash_design | ||
| description: Shared styles for Dart and Flutter websites. | ||
| version: 0.0.1-wip | ||
| publish_to: none | ||
| repository: https://github.com/dart-lang/site-shared/tree/main/pkgs/dash_design | ||
|
|
||
| environment: | ||
| sdk: ^3.5.0 | ||
|
|
||
| dev_dependencies: | ||
| analysis_defaults: | ||
| path: ../analysis_defaults | ||
| path: ^1.9.0 | ||
| sass: ^1.79.4 | ||
| test: ^1.25.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| import 'dart:isolate'; | ||
|
|
||
| import 'package:path/path.dart' as path; | ||
| import 'package:sass/sass.dart' as sass; | ||
| import 'package:test/test.dart'; | ||
|
|
||
| void main() { | ||
| test('Can build styles.scss file', () { | ||
| final compileResult = sass.compileToResult(_stylesPath!, | ||
| fatalDeprecations: sass.Deprecation.values.where((d) => !d.isFuture)); | ||
| expect(compileResult.css, contains('--dash-default-font-family')); | ||
| }); | ||
| } | ||
|
|
||
| String? get _stylesPath { | ||
| final packageUri = Uri.parse('package:dash_design/styles.scss'); | ||
| final resolvedUri = Isolate.resolvePackageUriSync(packageUri); | ||
| if (resolvedUri == null) return null; | ||
| if (!resolvedUri.isScheme('file')) return null; | ||
| return path.fromUri(resolvedUri); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should investigate if
package:sass_apicould be used for something like that.I think if it would be part of the Dart toolchain, nobody would mind it, however, if it is IDE-based or required extra setup, it would cause a lot more friction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started investigating this and if it works out well, I'll open a follow-up PR to add it and get feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure it's possible to build one on-top of
analyzer_pluginusingsass_api-- but it might also be a somewhat large project 🤣