Upgrade to build 0.9.0 #145
Merged
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
natebosch
commented
Apr 25, 2017
natebosch
commented
- Replace declareOutputs with buildExtensions
- Upgrade build related dependencies
- Replace declareOutputs with buildExtensions - Upgrade build related dependencies
jakemac53
approved these changes
Apr 25, 2017
|
FYI, @natebosch – might could have updated the min SDK constraint to |
|
Min SDK constraint was already 1.21.1 |
|
Er 1.22.1
From mobile. Sorry for brevity and/or spelling.
…On Jun 14, 2017 4:48 AM, "Nate Bosch" ***@***.***> wrote:
Min SDK constraint was already 1.21.1
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#145 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCigOSc4gZWtghpwyXEpfIL4vJ773Hks5sD0oZgaJpZM4NH2ey>
.
|
|
Since the SDK constraint is tightened in package:build rather than by usage here I don't think it makes sense to update this constraint - we let pub figure that out for us. IMO it doesn't make sense to transitively search a package's dependencies to find the SDK constraint but to specify it based on language usage within this package. |
For me it's about support. If we can't test version X, we shouldn't claim to support it. |
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
- Replace declareOutputs with buildExtensions - Upgrade build related dependencies - Disable tests against sdk 1.21.1
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
- Replace declareOutputs with buildExtensions - Upgrade build related dependencies - Disable tests against sdk 1.21.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.