added optional associatedElement param to InvalidGenerationSourceError
#324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
Apr 9, 2018
lib/src/generator.dart
Outdated
| /// The code element associated with this error. | ||
| /// | ||
| /// May be `null` if the error had no associated element. | ||
| final Element associatedElement; |
There was a problem hiding this comment.
I'm not sure if the word "associated" is making this more clear than it would be with only "element"
|
ack – PTAL
…On Mon, Apr 9, 2018 at 1:26 PM Nate Bosch ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/src/generator.dart
<#324 (comment)>:
> @@ -36,9 +38,26 @@ class InvalidGenerationSourceError extends Error {
/// May be an empty string if unknown.
final String todo;
- InvalidGenerationSourceError(this.message, {String todo})
+ /// The code element associated with this error.
+ ///
+ /// May be `null` if the error had no associated element.
+ final Element associatedElement;
I'm not sure if the word "associated" is making this more clear than it
would be with only "element"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#324 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCih9ig7CCNZuZf8jUbIpYZjLrfQpFks5tm8PigaJpZM4TNJxO>
.
|
natebosch
approved these changes
Apr 9, 2018
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.