avoid computeNode calls #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going through computeNode() and AST types is not guaranteed to work for all Element sources. Instead go through only statically available Element types. - Avoid computeNode() on the ConstructorElement by reading parameters and names directly - Avoid computedNode() on the PropertyAccessorElement.variable by checking if it is a ConstVariableElement with an available InstanceCreationExpression - Update imports for Element classes to a non-deprecated library
|
nice! lgtm |
lib/src/annotation.dart
Outdated
| } else { | ||
| ctorName = new Symbol(ctorDeclaration.name.name); | ||
| } | ||
| Symbol ctorName = new Symbol(ctor.name ?? ''); |
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
* avoid computeNode calls in annotation.dart Going through computeNode() and AST types is not guaranteed to work for all Element sources. Instead go through only statically available Element types. - Avoid computeNode() on the ConstructorElement by reading parameters and names directly - Avoid computedNode() on the PropertyAccessorElement.variable by checking if it is a ConstVariableElement with an available InstanceCreationExpression - Update imports for Element classes to a non-deprecated library * Bump version and update changelog * Fix unnecessarily typed variable
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
* avoid computeNode calls in annotation.dart Going through computeNode() and AST types is not guaranteed to work for all Element sources. Instead go through only statically available Element types. - Avoid computeNode() on the ConstructorElement by reading parameters and names directly - Avoid computedNode() on the PropertyAccessorElement.variable by checking if it is a ConstVariableElement with an available InstanceCreationExpression - Update imports for Element classes to a non-deprecated library * Bump version and update changelog * Fix unnecessarily typed variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes annotation.dart forward compatible with implementations of the Resolvers and LibraryElement using analyzer summary files.