-
Notifications
You must be signed in to change notification settings - Fork 74
Bump deps for graphs, html, process, pubspec_parse #2210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
## 0.15.7-wip | ||
|
||
- Require Dart `3.6` | ||
|
||
## 0.15.6 | ||
|
||
- Performance improvements. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,5 +16,5 @@ dependencies: | |
platform: '^3.0.0' | ||
|
||
dev_dependencies: | ||
lints: ^5.0.0 | ||
lints: ^6.0.0 | ||
test: ^1.16.8 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
## 1.5.1-wip | ||
|
||
- Require Dart 3.8 | ||
|
||
## 1.5.0 | ||
|
||
- Added fields to `Pubspec`: `executables`, `resolution`, `workspace`. | ||
|
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -46,14 +46,17 @@ Dependency? _fromJson(Object? data, String name) { | |||||||||||||
} | ||||||||||||||
|
||||||||||||||
if (data is Map) { | ||||||||||||||
final matchedKeys = | ||||||||||||||
data.keys.cast<String>().where((key) => key != 'version').toList(); | ||||||||||||||
final matchedKeys = data.keys | ||||||||||||||
.cast<String>() | ||||||||||||||
.where((key) => key != 'version') | ||||||||||||||
.toList(); | ||||||||||||||
|
||||||||||||||
if (data.isEmpty || (matchedKeys.isEmpty && data.containsKey('version'))) { | ||||||||||||||
return _$HostedDependencyFromJson(data); | ||||||||||||||
} else { | ||||||||||||||
final firstUnrecognizedKey = | ||||||||||||||
matchedKeys.firstWhereOrNull((k) => !_sourceKeys.contains(k)); | ||||||||||||||
final firstUnrecognizedKey = matchedKeys.firstWhereOrNull( | ||||||||||||||
(k) => !_sourceKeys.contains(k), | ||||||||||||||
); | ||||||||||||||
|
||||||||||||||
return $checkedNew<Dependency>('Dependency', data, () { | ||||||||||||||
if (firstUnrecognizedKey != null) { | ||||||||||||||
|
@@ -78,8 +81,9 @@ Dependency? _fromJson(Object? data, String name) { | |||||||||||||
'git' => GitDependency.fromData(data[key]), | ||||||||||||||
'path' => PathDependency.fromData(data[key]), | ||||||||||||||
'sdk' => _$SdkDependencyFromJson(data), | ||||||||||||||
'hosted' => _$HostedDependencyFromJson(data) | ||||||||||||||
..hosted?._nameOfPackage = name, | ||||||||||||||
'hosted' => _$HostedDependencyFromJson( | ||||||||||||||
data, | ||||||||||||||
)..hosted?._nameOfPackage = name, | ||||||||||||||
_ => throw StateError('There is a bug in pubspec_parse.'), | ||||||||||||||
}; | ||||||||||||||
}); | ||||||||||||||
|
@@ -99,7 +103,7 @@ class SdkDependency extends Dependency { | |||||||||||||
final VersionConstraint version; | ||||||||||||||
|
||||||||||||||
SdkDependency(this.sdk, {VersionConstraint? version}) | ||||||||||||||
: version = version ?? VersionConstraint.any; | ||||||||||||||
: version = version ?? VersionConstraint.any; | ||||||||||||||
|
||||||||||||||
@override | ||||||||||||||
bool operator ==(Object other) => | ||||||||||||||
|
@@ -215,7 +219,7 @@ class HostedDependency extends Dependency { | |||||||||||||
final HostedDetails? hosted; | ||||||||||||||
|
||||||||||||||
HostedDependency({VersionConstraint? version, this.hosted}) | ||||||||||||||
: version = version ?? VersionConstraint.any; | ||||||||||||||
: version = version ?? VersionConstraint.any; | ||||||||||||||
Comment on lines
221
to
+222
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This public constructor lacks documentation. The repository style guide requires all public members to be documented to improve clarity.1
Suggested change
Style Guide ReferencesFootnotes
|
||||||||||||||
|
||||||||||||||
@override | ||||||||||||||
bool operator ==(Object other) => | ||||||||||||||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -57,19 +57,15 @@ class Pubspec { | |||||||||||
/// If there is exactly 1 value in [authors], returns it. | ||||||||||||
/// | ||||||||||||
/// If there are 0 or more than 1, returns `null`. | ||||||||||||
@Deprecated( | ||||||||||||
'See https://dart.dev/tools/pub/pubspec#authorauthors', | ||||||||||||
) | ||||||||||||
@Deprecated('See https://dart.dev/tools/pub/pubspec#authorauthors') | ||||||||||||
String? get author { | ||||||||||||
if (authors.length == 1) { | ||||||||||||
return authors.single; | ||||||||||||
} | ||||||||||||
return null; | ||||||||||||
} | ||||||||||||
|
||||||||||||
@Deprecated( | ||||||||||||
'See https://dart.dev/tools/pub/pubspec#authorauthors', | ||||||||||||
) | ||||||||||||
@Deprecated('See https://dart.dev/tools/pub/pubspec#authorauthors') | ||||||||||||
final List<String> authors; | ||||||||||||
Comment on lines
+68
to
69
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This public field
Suggested change
Style Guide ReferencesFootnotes
|
||||||||||||
final String? documentation; | ||||||||||||
|
||||||||||||
|
@@ -109,13 +105,9 @@ class Pubspec { | |||||||||||
this.name, { | ||||||||||||
this.version, | ||||||||||||
this.publishTo, | ||||||||||||
@Deprecated( | ||||||||||||
'See https://dart.dev/tools/pub/pubspec#authorauthors', | ||||||||||||
) | ||||||||||||
@Deprecated('See https://dart.dev/tools/pub/pubspec#authorauthors') | ||||||||||||
String? author, | ||||||||||||
@Deprecated( | ||||||||||||
'See https://dart.dev/tools/pub/pubspec#authorauthors', | ||||||||||||
) | ||||||||||||
@Deprecated('See https://dart.dev/tools/pub/pubspec#authorauthors') | ||||||||||||
List<String>? authors, | ||||||||||||
Map<String, VersionConstraint?>? environment, | ||||||||||||
this.homepage, | ||||||||||||
|
@@ -134,14 +126,16 @@ class Pubspec { | |||||||||||
Map<String, Dependency>? dependencyOverrides, | ||||||||||||
this.flutter, | ||||||||||||
Map<String, String?>? executables, | ||||||||||||
}) : | ||||||||||||
// ignore: deprecated_member_use_from_same_package | ||||||||||||
authors = _normalizeAuthors(author, authors), | ||||||||||||
environment = environment ?? const {}, | ||||||||||||
dependencies = dependencies ?? const {}, | ||||||||||||
devDependencies = devDependencies ?? const {}, | ||||||||||||
executables = executables ?? const {}, | ||||||||||||
dependencyOverrides = dependencyOverrides ?? const {} { | ||||||||||||
}) : authors // ignore: deprecated_member_use_from_same_package | ||||||||||||
= _normalizeAuthors( | ||||||||||||
author, | ||||||||||||
authors, | ||||||||||||
), | ||||||||||||
environment = environment ?? const {}, | ||||||||||||
dependencies = dependencies ?? const {}, | ||||||||||||
devDependencies = devDependencies ?? const {}, | ||||||||||||
executables = executables ?? const {}, | ||||||||||||
dependencyOverrides = dependencyOverrides ?? const {} { | ||||||||||||
if (name.isEmpty) { | ||||||||||||
throw ArgumentError.value(name, 'name', '"name" cannot be empty.'); | ||||||||||||
} | ||||||||||||
|
@@ -189,10 +183,7 @@ class Pubspec { | |||||||||||
); | ||||||||||||
|
||||||||||||
static List<String> _normalizeAuthors(String? author, List<String>? authors) { | ||||||||||||
final value = <String>{ | ||||||||||||
if (author != null) author, | ||||||||||||
...?authors, | ||||||||||||
}; | ||||||||||||
final value = <String>{if (author != null) author, ...?authors}; | ||||||||||||
return value.toList(); | ||||||||||||
} | ||||||||||||
} | ||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This public constructor lacks documentation. The repository style guide requires all public members to be documented to improve clarity.1
Style Guide References
Footnotes
The style guide states that at least all public members should have documentation. ↩