-
Notifications
You must be signed in to change notification settings - Fork 78
Fix doc comment bugs, enable the corresponding lint #2245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Now that the underlying bug is fixed Also flagged a couple of TODOs – but requires a breaking change to be careful
|
@srawlins – would LOVE unused But guessing you know all of these already? |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses broken documentation comments, which allows for the comment_references lint to be enabled. The changes are clean and well-targeted. I appreciate that you've also taken the time to identify areas for future improvement by adding TODOs and deprecating parts of the API that are implementation details. This will help improve the package's maintainability in the long run.
I have one minor suggestion to improve the clarity of a deprecation message. Overall, great work!
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| markdown | Non-Breaking | 7.3.0 | 7.3.1-wip | 7.4.0 Got "7.3.1-wip" expected >= "7.4.0" (non-breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Coverage ⚠️
| File | Coverage |
|---|---|
| pkgs/markdown/lib/markdown.dart | 💔 Not covered |
| pkgs/markdown/lib/src/block_parser.dart | 💚 91 % |
| pkgs/markdown/lib/src/inline_syntaxes/footnote_ref_syntax.dart | 💚 100 % |
| pkgs/markdown/lib/src/inline_syntaxes/link_syntax.dart | 💚 99 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
Changelog Entry ❗
| Package | Changed Files |
|---|---|
| package:markdown | pkgs/markdown/lib/markdown.dart pkgs/markdown/lib/src/block_parser.dart pkgs/markdown/lib/src/inline_syntaxes/footnote_ref_syntax.dart pkgs/markdown/lib/src/inline_syntaxes/link_syntax.dart |
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.
|
Gah! I should document the deprecations in the changelog! |
Now that the underlying bug is fixed
Also flagged a couple of TODOs – but requires a breaking change to be careful