Skip to content

Conversation

@srujzs
Copy link
Contributor

@srujzs srujzs commented Oct 15, 2025

Making a breaking change to avoid breaking any existing users of package:js_interop. Also modifies the monorepo's README to detail the packages within rather than being a symlink to web's README.

Making a breaking change to avoid breaking any existing users of
package:js_interop. Also modifies the monorepo's README to detail
the packages within rather than being a symlink to web's README.
@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:js_interop 0.1.0-beta ready to publish js_interop-v0.1.0-beta
package:web 2.0.0-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@srujzs srujzs requested a review from kevmoo October 15, 2025 22:00
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@nikeokoronkwo
Copy link
Collaborator

nikeokoronkwo commented Oct 15, 2025

I was thinking we'd make the generator script usable as a package before publishing? Sorry noticed that package:js_interop is a different package entirely

@srujzs srujzs merged commit 5a7d0be into dart-lang:main Oct 16, 2025
8 checks passed
@devoncarew
Copy link
Member

We may consider refactoring this mono-repo so that its packages are in a pkgs/ sub-directory. That would mirror our other mono-repos (https://github.com/dart-lang/core, https://github.com/dart-lang/tools, ...), and would play better w/ some of our home-grown tools.

Concretely I think that would look like:

  • js_interop => pkgs/js_interop
  • web => pkgs/web
  • web_generator => either tool/web_generator or pkgs/web_generator

Thoughts?

@srujzs
Copy link
Contributor Author

srujzs commented Oct 20, 2025

Moving them to pkgs/ sounds good to me. There may be some path-specific code that will need to be changed.

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 21, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

protobuf (https://github.com/dart-lang/protobuf/compare/14bbd0b..78cf743):
  78cf743  2025-10-20  Ömer Sinan Ağacan  Fix a few extension field bugs (google/protobuf.dart#1062)

tools (https://github.com/dart-lang/tools/compare/f5920a2..d0941a3):
  d0941a35  2025-10-17  Morgan :)  Unify watcher tests (dart-lang/tools#2211)
  fa978cd2  2025-10-17  Morgan :)  Remove backup expectations (dart-lang/tools#2209)

web (https://github.com/dart-lang/web/compare/816abcc..5a7d0be):
  5a7d0be  2025-10-16  Srujan Gaddam  Initial commit of package:js_interop 0.1.0-beta (dart-lang/web#476)

webdev (https://github.com/dart-lang/webdev/compare/2517aa9..82b3855):
  82b38557  2025-10-20  Jessy Yameogo  [DWDS] Fixes hot reload/restart crashes after closing browser tab on web-server device  (dart-lang/webdev#2699)

Change-Id: I98c840892d243f3dc34f9409956d8726ff84238a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/456040
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants