Daemon fails to launch Chrome on Windows

[DanTup]

When trying to run on Windows, Chrome fails to launch:

CreateProcess
W failed 2
Unhandled exception:
ProcessException: The system cannot find the file specified.
  Command: Google\Chrome\Application\chrome.exe --user-data-dir=M:\Coding\xxxxxxxx\.dart_tool\webdev\chrome_profile --remote-debugging-port=58363 --disable-background-timer-throttling --disable-extensions --disable-popup-blocking --bwsi --no-first-run --no-default-browser-check --disable-default-apps --disable-translate http://localhost:58356/
#0      Chrome.start (package:webdev/src/serve/chrome.dart:88:19)

I'm not sure if this is particular to how I installed Chrome, but the executable path for Windows does look a bit suspicious (see

webdev/webdev/lib/src/serve/chrome.dart

Line 18 in 662ea5c

const _windowsExecutable = r'Google\Chrome\Application\chrome.exe';

).

On my machine, Chrome is at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe but I suspect it can probably be in %APPDATA% too.

[jakemac53]

I think we just borrowed this from the test package, but I wonder if it is doing something else special with that path?

[jakemac53]

Ah, looks like we are missing this logic https://github.com/dart-lang/test/blob/ac21330338e0a7ad68fb19058bb92260706dd6cf/pkgs/test/lib/src/runner/executable_settings.dart#L46.

cc @kenzieschmoll as well if you are still looking at a general browser package

[DanTup]

Works now, thanks!