Fix hot restart race by pausing the app before hot restart #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2021 11:19
A race between app hitting a breakpoint and a hot restart was causing hot restart to hang. Pause the app (if it is not already paused) forcefully before hot restarting to prevent this from happening. Closes: dart-lang#1359
grouma
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
A race between the app hitting a breakpoint and a hot restart was causing hot restart to hang periodically.
The race sequence was as following:
not resume the isolate.
As a result, the app is paused and hot restart hangs.
Solution
Pause the app (if it is not already paused) forcefully and wait for the either breakpoint or the pause event on
the debug stream before hot restarting to prevent this from happening.
Closes: #1359