Skip to content

Fix test break due to changed compiler error, do not use pub directly #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2021
Merged

Fix test break due to changed compiler error, do not use pub directly #1397

merged 1 commit into from
Aug 31, 2021

Conversation

@annagrin
Copy link
Contributor

@annagrin annagrin commented Aug 31, 2021

  • Fix test break due to changed compiler error
    Make sure the test does not break due to such changes in the future.
  • Do not use pub directly in tests as it is deprecated.

@google-cla google-cla bot added the cla: yes label Aug 31, 2021
@annagrin annagrin merged commit 59e73ff into dart-lang:master Aug 31, 2021
@annagrin annagrin deleted the annagrin/compilation_error_messages branch August 31, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nshahan nshahan Awaiting requested review from nshahan

@jakemac53 jakemac53 Awaiting requested review from jakemac53

1 more reviewer

@grouma grouma grouma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@annagrin @grouma