migdate fixtures/_testPackage #1653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
approved these changes
Jun 13, 2022
annagrin
reviewed
Jun 14, 2022
Contributor
annagrin
left a comment
annagrin
left a comment
There was a problem hiding this comment.
Apologies for not letting you know earlier and saving you the effort! those tests should stay as weak to test that the debugger work with weak null safety. We have matching matching null safe versions that we use in our test a well.
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| // @dart = 2.9 |
Contributor
There was a problem hiding this comment.
This code is for testing that debugger works with weak null safety so we should not migrate the _webdevSmoke. The matching null safe version is located next to it under _webdevSoundSmoke.
Contributor
|
Merging this since it is ready, thanks @jacob314 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.