Remove logger name when not verbose #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Apr 22, 2019
Contributor
jakemac53
left a comment
jakemac53
left a comment
There was a problem hiding this comment.
I think this is deserving of some specific unit tests to cover some of the potential edge cases (multiple colons, colons in the log message but no actual logger name provided, empty log message with a logger name, etc)
jakemac53
approved these changes
Apr 22, 2019
natebosch
added a commit
to dart-lang/build
that referenced
this pull request
Apr 22, 2019
Now that there is a split with some of these logger names coming from `build_runner_core` it's not as easy to roll out changes which introduce new logger names. The only cases where we do want to show the logger name are the ones where we are running actions and will always fit the pattern of `'$builderLabel on $input'`. `wevdev` parses out logger names and discards any which contain a space: dart-lang/webdev#305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assumes the logger names do not contain spaces. Based off of dart-lang/build#2194 this assumption appears correct.
Closes #301