Skip to content

Move Webdev injected client tests over to DWDS #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2019
Merged

Move Webdev injected client tests over to DWDS #495

merged 2 commits into from
Jul 16, 2019

Conversation

@grouma
Copy link
Member

@grouma grouma commented Jul 16, 2019 •
edited
Loading

Mostly finishes #475 (just waiting on a publish)

Now that the injected client is a part of package:dwds it doesn't make sense that webdev is testing this logic. Move the corresponding tests over to package:dwds and delete them from webdev.

@grouma grouma requested a review from jakemac53 July 16, 2019 00:39
@grouma grouma merged commit 8637a09 into master Jul 16, 2019
@grouma grouma deleted the more-test-cleanup branch July 16, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grouma @jakemac53