Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BUILD_SHARED_LIBS set to ON on Windows/MSVC #1501

Closed
traversaro opened this issue Sep 17, 2020 · 5 comments
Closed

Support BUILD_SHARED_LIBS set to ON on Windows/MSVC #1501

traversaro opened this issue Sep 17, 2020 · 5 comments
Labels
help wanted Indicates wanting help on an issue or pull request os: windows Windows specific issues
Milestone

Comments

@traversaro
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Given its huge size, for some applications it is convenient to be able to compiled dart as a shared library on Windows/MSVC, to permit to share it among multiple executable.

Additional context
Discussion on this was ongoing on #1005, but that issue was closed as its main objective was reached without the need to make sure that DART supported being compiled as a shared library on Windows.

@jslee02
Copy link
Member

jslee02 commented Sep 18, 2020

Do you know what's preventing us from building DART as shared libraries? Doesn't BUILD_SHARED_LIBS work as it is?

@traversaro
Copy link
Contributor Author

To be honest I did not tried myself, but from #1005 it seems that the situation is the following:

  • The CMake variable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS does not work as the library has more then 65k symbols, see Submit DART port to vcpkg #1005 (comment) .
  • An attempt was made in C++ visibility support #1040 to add explicit visibility macros, but i guess there were some problem/doubts on where to add visibility macros for heavily templated class, and then eventually the PR was not completed.

@jslee02 jslee02 assigned jslee02 and unassigned jslee02 Oct 17, 2020
@jslee02 jslee02 added the help wanted Indicates wanting help on an issue or pull request label Oct 17, 2020
@jslee02 jslee02 added this to the DART 7.0.0 milestone Jul 12, 2021
@jslee02 jslee02 added the os: windows Windows specific issues label Jan 8, 2023
@jslee02
Copy link
Member

jslee02 commented Jan 14, 2023

Fixed by d78c328

@jslee02 jslee02 closed this as completed Jan 14, 2023
@traversaro
Copy link
Contributor Author

Great, thanks a lot!

@jslee02
Copy link
Member

jslee02 commented Jan 14, 2023

Thanks for being patient with this. I had to implement some workarounds and make adjustments to the code to get it working. I will be addressing these issues and making improvements in future commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates wanting help on an issue or pull request os: windows Windows specific issues
Projects
None yet
Development

No branches or pull requests

2 participants