Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python bindings for pointcloud and contact retrieval #1455

Merged

Conversation

chhinze
Copy link
Contributor

@chhinze chhinze commented Apr 29, 2020

  1. Adds Python bindings for the following:

    • Extracting contacts from CollisionResult object (Methods getContact and getContacts)
    • PointCloudShape, so it is now possible to draw pointclouds in dartpy as well
  2. Adds an example python/examples/contacts_pointcloud/main.py, which is basically the hello_world_gui example (robot and ground are set transparent) with detection of contacts and visualization as a pointcloud before each GUI refresh.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) Example for this change

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #1455 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1455      +/-   ##
==========================================
+ Coverage   58.21%   58.23%   +0.02%     
==========================================
  Files         412      412              
  Lines       29923    29923              
==========================================
+ Hits        17419    17425       +6     
+ Misses      12504    12498       -6     
Impacted Files Coverage Δ
dart/dynamics/EulerJoint.cpp 73.00% <0.00%> (+3.68%) ⬆️

@jslee02 jslee02 added this to the DART 6.10.0 milestone May 1, 2020
jslee02
jslee02 previously approved these changes May 1, 2020
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding these bindings.

python/examples/contacts_pointcloud/main.py Outdated Show resolved Hide resolved
@jslee02 jslee02 force-pushed the fix/BindingsForPointcloudAndContactRetreival branch from da71a05 to 1b31882 Compare May 1, 2020 03:41
Co-authored-by: Jeongseok Lee <jslee02@users.noreply.github.com>
@jslee02 jslee02 merged commit 4f9b738 into dartsim:master May 1, 2020
@chhinze
Copy link
Contributor Author

chhinze commented May 3, 2020

Thank you for reviewing and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants