Skip to content

Conversation

@demlenar
Copy link
Contributor

@demlenar demlenar commented Nov 6, 2022

Hi There,

I added a string class (Str) that was missing along with tests for it. Does it all look okay? Let me know if there is anything that needs to be updated.

Thanks!

Closes #13

@das-intensity das-intensity self-assigned this Nov 6, 2022
@das-intensity
Copy link
Owner

Thanks for the PR!

The failures seem to be related to outdated CI setup, unrelated to your changes. Can you try modifying .github/workflows/test.yml to add another env var to Code coverage with coveralls section: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}?

@das-intensity
Copy link
Owner

Can you make one more change there, change

run: coveralls

to

run: coveralls --service=github

@das-intensity
Copy link
Owner

Seems there was an issue with unpinned wrapt on python <= 3.4. I've pinned this in requirements on master branch, please rebase and that should be solved.

@das-intensity
Copy link
Owner

Looks like github dropped support for pull requests to use secrets entirely. I've updated this on master, please rebase, sorry for all the run-around just for the sake of CI.

@das-intensity das-intensity merged commit 700d8fe into das-intensity:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Str class

2 participants