Fixes and Improvements for multi-node test runs #374
Conversation
fmoessbauer
left a comment
fmoessbauer
left a comment
There was a problem hiding this comment.
Thanks for the fixes. See my comments inline.
| DART_LOG_TRACE("dart_waitall_local: cannot free request %zu " | ||
| "mpi_sta[%zu] = %d (%s)", | ||
| r_n, | ||
| if (handle[i]->request) { |
There was a problem hiding this comment.
I am surprised that this even worked in the past...
| // re-use previously allocated memory | ||
| if (segment->baseptr == NULL) { | ||
| segment->baseptr = malloc(sizeof(char *) * team_data->sharedmem_nodesize); | ||
| segment->baseptr = calloc(team_data->sharedmem_nodesize, sizeof(char *)); |
There was a problem hiding this comment.
calloc should not be necessary here, but who cares ;)
| typename ElementType, | ||
| class PatternType, | ||
| class UnaryFunction > | ||
| void generate_with_index( |
There was a problem hiding this comment.
Cool, I missed this function quite often.
| /// Generator function | ||
| UnaryFunction gen) { | ||
| /// Global iterators to local index range: | ||
| auto index_range = dash::local_index_range(first, last); |
There was a problem hiding this comment.
Better use the new range based views, as this does not work with multiple local ranges AFAIK. Maybe @fuchsto can assist.
There was a problem hiding this comment.
Do you have any pointer on how to use them? I'm not sure range based views and I have crossed paths so far...
There was a problem hiding this comment.
Hey, I even introduced you personally last time in Munich!
Anyways: yes, I will add documentation.
For usage you can refer to quite an abundance of tests in dash/test/view.
There was a problem hiding this comment.
To be honest, I don't even know where to start looking. I guess I could crawl through a host of undocumented code, still not knowing where to start or how to put the pieces together...
| auto & pattern = first.pattern(); | ||
| auto first_offset = first.pos(); | ||
| // Iterate local index range: | ||
| for (auto lindex = lbegin_index; |
I tried to run our test suite on multiple nodes on our cluster and came across some bugs that don't seem to manifest as errors if running on one node only. In particular, this PR contains fixes to the handling of
MPI_Requestobjects and an issue in our shared memory optimization.Additionally, this PR adds
dash::generate_with_indexto enable parallel generation of container values in cases where the generated value depends on the index of the element. This function is applied to two tests in which the serial generation was really slow on 8 nodes.