Update install instruction to align with latest makefile #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile seem to have been updated in #ff8aa6b346bd4fe6781fe70a463457c331dcc945. This PR is just updating the README.md to use make install instead of make build for the end users. Coupled are just minor auto-format changes.
Owner
|
Thanks! |
dashed
added a commit
that referenced
this pull request
Aug 29, 2025
The PR tests were failing in CI because the mock gh executable path wasn't being passed to the subprocess. Tests modified PATH with env::set_var() but this only affected the current process, not subprocesses spawned by assert_cmd. Changes: - Add run_test_bin_with_env() helper to pass environment variables to subprocesses - Update all PR tests that use mock gh to pass PATH explicitly - Remove unnecessary env::set_var() and env::restore() calls This fixes the test_list_command_with_pr_flag failure that was causing CI to fail on the master branch after PR #45.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile seem to have been updated in #ff8aa6b346bd4fe6781fe70a463457c331dcc945. This PR is just updating the README.md to use make install instead of make build for the end users.
Coupled are just minor auto-format changes.