This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Use net_http as default HTTP adapter for Jruby #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmulvihill
changed the title
Contributor
|
@bmulvihill the update for JRuby looks good. Can you add JRuby to the list of Ruby versions that are verified by TravisCI? This will make sure it doesn't get broken in the future. https://github.com/dashofcode/tracker_api/blob/master/.travis.yml#L9 |
Contributor
Author
|
@forest I had to switch the VCR stubbing to use faraday in order for Jruby to pass the specs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123
Currently
excondoes not work out of the box with Jruby due to a more restrictive cipher set. In order to prevent usability issues this sets the default adapter tonet_httpfor Jruby