feat: validate .env in init#199
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking for presence of the
.envand loading its content was previously done in two places: in thedash-networkcommand wrapper and in thegeneratecommand. This PR removes the duplicate code and moves the check into the init function.Issue being fixed or feature implemented
This fixes the chicken/egg problem of not having an
.envfile and not being able to create one becauseinit.shchecks for its existence first, and also the problem of overwriting existing.envfiles when runninggenerate.What was done?
Remove
.envforced exit indash-networkand check/generate ininit.shinstead of in the generate command.How Has This Been Tested?
Tested running
bin/generatefrom shell anddash-network generatewith docker.Breaking Changes
None
Checklist:
For repository code-owners and collaborators only