merge bitcoin#10973: separate wallet from node #4513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2021
|
Thanks for opening this for me 👍 I'm gonna close this and break it into a number of PRs: |
kwvg
force-pushed
the
pasta-14146
branch
2 times, most recently
from
a2a611c
to
234cd0b
Compare
kwvg
changed the title
kwvg
changed the title
|
tests failing |
PastaPastaPasta
previously approved these changes
Oct 19, 2021
kwvg
force-pushed
the
pasta-14146
branch
2 times, most recently
from
26f3988
to
d75e1e0
Compare
UdjinM6
changed the title
UdjinM6
requested changes
Oct 22, 2021
|
Seems like this PR has an odd quirk, I'll close it for now |
kwvg
changed the title
PastaPastaPasta
requested changes
Oct 31, 2021
|
Superseded by #4558 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
Remove uses of chainActive and mapBlockIndex in wallet code bitcoin/bitcoin#14711's backport has been
stolenborrowed from Backport 14711, 15342, partial 15855 #4537 and used as a placeholder for the source PR.This PR therefore, depends on it.
MAX_ANTI_FEE_SNIPING_TIP_AGEhas been changed from8 * 60 * 60to4 * 60when backporting wallet: Avoid leaking nLockTime fingerprint when anti-fee-sniping bitcoin/bitcoin#15039 to satisfy thewallet_create_tx.pyfunctional testRemove wallet -> node global function calls bitcoin/bitcoin#15288
only includes the range between 80f52a2 and 00dfb2ahas been fully backported (but still excludes bdc6628)test: Add wallet_balance benchmark bitcoin/bitcoin#15779 was a partial backport done in merge bitcoin#13219...#15779: benchmarks #4511 as it relied on Refactor: separate wallet from node bitcoin/bitcoin#10973 (which is backported in this PR), as we fulfill that dependency in this PR, the rest of it has been backported as well, making it complete