-
Notifications
You must be signed in to change notification settings - Fork 72
[Review] Add gpu tests for string functions #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Review] Add gpu tests for string functions #256
Conversation
|
I'm guessing this is a one off network error, but curious if you've seen this before @charlesbluca : |
|
I haven't seen that issue before - do you mind rerunning tests here? |
|
Seems to have been a one-off 🙂 |
Codecov Report
@@ Coverage Diff @@
## main #256 +/- ##
==========================================
+ Coverage 95.74% 95.82% +0.07%
==========================================
Files 64 64
Lines 2750 2800 +50
Branches 412 424 +12
==========================================
+ Hits 2633 2683 +50
Misses 75 75
Partials 42 42
Continue to review full report at Codecov.
|
|
Should be good for another round of reviews, cc: @quasiben @galipremsagar |
|
@charlesbluca Could you have a look at it before we merge this? Looks like your review comments are addressed. |
charlesbluca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ayushdg!
Adds gpu tests for string functions in dask-sql