Skip to content

Conversation

@ayushdg
Copy link
Collaborator

@ayushdg ayushdg commented Oct 13, 2021

Adds gpu tests for string functions in dask-sql

@ayushdg
Copy link
Collaborator Author

ayushdg commented Oct 13, 2021

I'm guessing this is a one off network error, but curious if you've seen this before @charlesbluca :

Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v2/dist/codecov' failed with exit code 255

@charlesbluca
Copy link
Collaborator

I haven't seen that issue before - do you mind rerunning tests here?

@charlesbluca
Copy link
Collaborator

Seems to have been a one-off 🙂

@ayushdg ayushdg marked this pull request as ready for review October 13, 2021 23:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #256 (d66c1fc) into main (5d8bb74) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   95.74%   95.82%   +0.07%     
==========================================
  Files          64       64              
  Lines        2750     2800      +50     
  Branches      412      424      +12     
==========================================
+ Hits         2633     2683      +50     
  Misses         75       75              
  Partials       42       42              
Impacted Files Coverage Δ
dask_sql/cmd.py 100.00% <0.00%> (ø)
dask_sql/datacontainer.py 94.11% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8bb74...d66c1fc. Read the comment docs.

@ayushdg ayushdg changed the title [WIP] Add gpu tests for string functions [Review] Add gpu tests for string functions Oct 13, 2021
@ayushdg
Copy link
Collaborator Author

ayushdg commented Oct 25, 2021

Should be good for another round of reviews, cc: @quasiben @galipremsagar

@galipremsagar
Copy link
Collaborator

@charlesbluca Could you have a look at it before we merge this? Looks like your review comments are addressed.

Copy link
Collaborator

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ayushdg!

@galipremsagar galipremsagar merged commit c27cf29 into dask-contrib:main Oct 27, 2021
@ayushdg ayushdg deleted the gpu-stringfunction-tests branch April 11, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants