Skip to content

Conversation

@enstenr
Copy link
Contributor

@enstenr enstenr commented Nov 21, 2025

This PR fixes several small documentation issues in bag.ipynb:

fixes
added missing word (“time”), ("footprint")
typo in lets -> let's
Added for more clarity-> For deeply nested data, consider flattening or using Bag first, then convert to DataFrame
user defined -> user-defined

These changes improve readability and consistency across the documentation.
No functional code has been modified.

Checklist
Updated documentation
No API changes
Notebook opens and renders as expected

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR strikes me as AI generated given the way the text is written in the description, especially the checklist. This is fine, but please make sure you review the diff yourself before submitting as there are a couple of clear problems where cell outputs haven't been cleared.

@enstenr
Copy link
Contributor Author

enstenr commented Nov 21, 2025

This PR strikes me as AI generated given the way the text is written in the description, especially the checklist. This is fine, but please make sure you review the diff yourself before submitting as there are a couple of clear problems where cell outputs haven't been cleared.

sure.
The output cell i did notice in ReviewNB after creating PR, in one of my earlier PR i had similar problem where the python version was showing different. When i google, i found that it was common and will be ignored by reviewer.
So i thought this was similar to this.
Now i understood this and will take care going forward. Hopefully now i have done it in correct way.

checklist - I provided gpt on what all i did and it formatted and gave in better phrase.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

@jacobtomlinson jacobtomlinson merged commit 092e8c4 into dask:main Nov 21, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants