-
-
Notifications
You must be signed in to change notification settings - Fork 156
Replace RPC with Scheduler HTTP API #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jacobtomlinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see this! A couple of comments.
Also, this does depend on an unreleased feature in distributed so we need to wait for a release before we can merge this and bump the minimum required distributed version.
jacobtomlinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting these fixes in @Matt711.
I tested this locally and it didn't quite seem to work so I pushed another commit with a fix.
This should be good to merge once dask/community/issues/245 is done and we can set distributed>=2022.05.1 in requirements.txt.
Did we get an answer to this? |
|
@mmccarty see #499 (review), just waiting on the next release now before we can merge 😁 |
|
Given that the HTTP API is still disabled by default in the latest release I've implemented some fallback options:
This should unblock us to merge now and also make it easier to support multiple Dask versions in the future. |
This PR replaces the call to the RPC object in favor of the new scheduler HTTP API.
Related Issue: #5935
Related PR: #6270