Skip to content

set cluster name via constructor to work around #dask/distributed/6485 #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2022
Merged

set cluster name via constructor to work around #dask/distributed/6485 #523

merged 2 commits into from
Jun 7, 2022

Conversation

@graingert
Copy link
Member

@graingert graingert commented Jun 6, 2022

Fixes #516

graingert added 2 commits June 6, 2022 10:04
@graingert
set cluster name via constructor
faeb8e3 
Fixes dask#516
@graingert
avoid capturing subprocess output when it's unused
6f04d5e 
pytest should capture the output with capfd so we can see
the log when interrupted by pytest-timeout
@graingert
Copy link
Member Author

graingert commented Jun 6, 2022

I added 6f04d5e to try and debug the TimeoutErrors in https://github.com/dask/dask-kubernetes/runs/6752846378?check_suite_focus=true but they didn't occur in the second run :(

@graingert
Copy link
Member Author

graingert commented Jun 6, 2022 •
edited
Loading

@jacobtomlinson I tried to move KubeCluster's self.name = into a super().__init__ call however the name is only computed in async def _start(

dask-kubernetes/dask_kubernetes/classic/kubecluster.py

Line 643 in c64b102

self.name = self.pod_template.metadata.generate_name

I think because self._fill_pod_templates( can only be called after await ClusterAuth.load_first(self.auth) - which can't be called in the constructor

dask-kubernetes/dask_kubernetes/classic/kubecluster.py

Line 582 in c64b102

await ClusterAuth.load_first(self.auth)

@graingert
Copy link
Member Author

graingert commented Jun 6, 2022

the self.name assignment in KubeCluster doesn't exhibit the problem in #516 because the assignment happens after Cluster.__init__ has been called.

@graingert graingert changed the title set cluster name via constructor set cluster name via constructor to work around https://github.com/dask/distributed/issues/6485 Jun 6, 2022
@graingert graingert changed the title set cluster name via constructor to work around https://github.com/dask/distributed/issues/6485 set cluster name via constructor to work around #dask/distributed/6485 Jun 6, 2022
jacobtomlinson
jacobtomlinson approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@jacobtomlinson jacobtomlinson merged commit 2c18242 into dask:main Jun 7, 2022
@graingert graingert deleted the set-name-via-constructor branch June 7, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HelmCluster cluster names get carried over to subsequent Clusters

2 participants

@graingert @jacobtomlinson