Skip to content

Assert port in dashboard link #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 29, 2022
Merged

Assert port in dashboard link #535

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d2516fe
Assert port in dashboard link
jacobtomlinson Jul 19, 2022
0e81177
Fix test
jacobtomlinson Jul 19, 2022
ebc88ef
Pin to last release
jacobtomlinson Jul 19, 2022
3faff95
Pin to 2022.6.1
jacobtomlinson Jul 19, 2022
b8095e2
Merge branch 'main' of github.com:dask/dask-kubernetes into explore-b…
jacobtomlinson Jul 29, 2022
e34e12d
Revert pinning
jacobtomlinson Jul 29, 2022
724e95e
Update test to check against the right port
jacobtomlinson Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dask_kubernetes/classic/tests/test_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ async def test_diagnostics_link_env_variable(k8s_cluster, pod_spec, user_env):
pytest.importorskip("bokeh")
with dask.config.set({"distributed.dashboard.link": "foo-{USER}-{port}"}):
async with KubeCluster(pod_spec, asynchronous=True) as cluster:
port = cluster.scheduler_info["services"]["dashboard"]
port = cluster.forwarded_dashboard_port

assert (
"foo-" + getpass.getuser() + "-" + str(port) in cluster.dashboard_link
Expand Down