fix versioneer for python3.12 #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate the fix here! I think it would be better to upgrade versioneer though instead of patching the specific issue. I ran the following commands and pushed a new commit: |
Comment on lines
+1
to
+5
| from . import _version | ||
| from .core import initialize, send_close_signal | ||
| from .exceptions import WorldTooSmallException | ||
|
|
||
| __version__ = get_versions()["version"] | ||
| del get_versions | ||
| __version__ = _version.get_versions()["version"] |
There was a problem hiding this comment.
I had to massage this a little as there was some duplication.
jacobtomlinson
approved these changes
Apr 29, 2024
|
Thanks, @jacobtomlinson @pbsds! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested building a wheel on python312 and python311
Same fix as in shaypal5/strct#4:
curl -L https://github.com/shaypal5/strct/pull/4.patch | git ampreferably you'd vendor a newer versioneer or switch to pyproject.toml