Correct Table.hist label when counts arg is provided #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good! Do you think the lowered coverage is worth improving? |
mDibyo
force-pushed
the
hist-label-correction
branch
from
67554e0 to
ac38f01
Compare
Contributor
Author
|
I added a doctest for it. Since the changes are visual (function returns None), the only way we could test it is through visual testing. Either that, or we could modify the function to return all the plot objects. We should do that for all the plotting functions, but this PR doesn't seem to be the right place for it. I will create an issue for that. In that case, the only way to improve coverage would be to add tests for some other parts, but don't want to add those to this pull request. |
Contributor
|
Right, that's very reasonable. |
SamLau95
added a commit
that referenced
this pull request
Oct 22, 2015
Correct Table.hist label when counts arg is provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #112.