Skip to content

Conversation

@maxwelljweinstein
Copy link
Contributor

[ ] Wrote test for feature
[ ] Added changes in the Changelog section in README.md
[ ] Bumped version number (delete if unneeded)

Changes proposed:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.894% when pulling 66bd8cb on take into 34cdae3 on master.

Copy link
Contributor

@SamLau95 SamLau95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment; this looks great! Go ahead and merge it after addressing it.

letter grade | gpa
B- | 2.7
>>> t.take([2, 1, 0])
>>> grades.take(make_array(2, 1, 0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you could also show an example with np.arange? That's a common case.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.894% when pulling d02bc9f on take into 34cdae3 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants