Joining on multiple columns #306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] Wrote test for feature
[x] Added changes in the Changelog section in README.md
[x] Bumped version number (please change if incorrect)
Changes proposed:
Addressing #305. In addition to the existing way of joining, now a list/array of columns can be passed in to join on.
A question on behavior and one on design:
joininto two functions, moving most of the original function to_joinand the new stuff to_multiple_join, but there's a lot of repetitive code. Would it be better to leave everything under join and use some more control statements?