Skip to content

BUG: preserve device for scalars with array input #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

BUG: preserve device for scalars with array input #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/array_api_extra/_lib/_utils/_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,10 @@ def asarrays(
}
kind = same_dtype[type(cast(complex, b))]
if xp.isdtype(a.dtype, kind):
xb = xp.asarray(b, dtype=a.dtype)
xb = xp.asarray(b, dtype=a.dtype, device=_compat.device(a))
else:
# Undefined behaviour. Let the function deal with it, if it can.
xb = xp.asarray(b)
xb = xp.asarray(b, device=_compat.device(a))

else:
# Neither a nor b are Array API objects.
Expand Down
13 changes: 13 additions & 0 deletions tests/test_funcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,6 +888,19 @@ def test_device(self, xp: ModuleType, device: Device, equal_nan: bool):
b = xp.asarray([1e-9, 1e-4, xp.nan], device=device)
res = isclose(a, b, equal_nan=equal_nan)
assert get_device(res) == device

def test_array_on_device_with_scalar(self, xp: ModuleType, device: Device):
a = xp.asarray([0.01, 0.5, 0.8, 0.9, 1.00001], device=device)
b = 1
res = isclose(a, b)
assert get_device(res) == device
xp_assert_equal(res, xp.asarray([False, False, False, False, True]))

a = 0.1
b = xp.asarray([0.01, 0.5, 0.8, 0.9, 0.100001], device=device)
res = isclose(a, b)
assert get_device(res) == device
xp_assert_equal(res, xp.asarray([False, False, False, False, True]))


class TestKron:
Expand Down