[PLUGIN-1932] Add hidden treatTimestampLTZAsTimestamp flag to map Oracle TIMESTAMP WITH LOCAL TIME ZONE to TIMESTAMP #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amit-CloudSufi
force-pushed
the
timestampLtz
branch
from
2938742 to
d9af2d2
Compare
| String role, Boolean useSSL, @Nullable Boolean treatAsOldTimestamp, | ||
| @Nullable Boolean treatPrecisionlessNumAsDeci) { | ||
| @Nullable Boolean treatPrecisionlessNumAsDeci, | ||
| @Nullable Boolean treatAsTimestampForLocalTimeZone) { |
There was a problem hiding this comment.
I think we can rename it to treatTimestampWithTzAsTimestamp as we want timestamp type for both Timestamp_LTZ and Timestamp_TZ
There was a problem hiding this comment.
- Please add details in the description: Jira ticket, testing etc.
- Do not use any internal naming like UCS.
- Please check the e2e tests
There was a problem hiding this comment.
Added JIra and testing Snapshot, removed UCS and for e2e we are checking, not related to our change.
vikasrathee-cs
changed the title
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSourceSchemaReader.java
Show resolved
Hide resolved
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConstants.java
Outdated
Show resolved
Hide resolved
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConnectorConfig.java
Outdated
Show resolved
Hide resolved
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConnectorConfig.java
Outdated
Show resolved
Hide resolved
vikasrathee-cs
changed the title
MrRahulSharma
approved these changes
Oct 1, 2025
vikasrathee-cs
force-pushed
the
timestampLtz
branch
from
0356be8 to
d75d92e
Compare
vikasrathee-cs
force-pushed
the
timestampLtz
branch
from
d75d92e to
c756ce9
Compare
vikasrathee-cs
merged commit 91dd191
into
data-integrations:develop
20 of 28 checks passed
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLUGIN-1932 Add hidden treatTimestampLTZAsTimestamp flag to map Oracle TIMESTAMP WITH LOCAL TIME ZONE to TIMESTAMP.
This issue requests the addition of a new, hidden configuration flag to the Oracle Database Source plugin. This flag will allow users to override the default type mapping for Oracle's TIMESTAMP WITH LOCAL TIME ZONE (TIMESTAMP_LTZ) data type.
By default, the Oracle Source plugin currently maps the Oracle data type TIMESTAMP WITH LOCAL TIME ZONE (TIMESTAMP_LTZ) to a DATETIME/STRING type.
For certain users, the intended target type in BigQuery for a local-time-aware timestamp is the BQ TIMESTAMP type, which includes time zone information