Skip to content

add support for ElasticSearch 7.5.2 with CDAP 6.1.1 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2020
Merged

add support for ElasticSearch 7.5.2 with CDAP 6.1.1 #17

merged 1 commit into from
Jun 29, 2020

Conversation

@shubhampatil17
Copy link
Contributor

@shubhampatil17 shubhampatil17 commented Apr 26, 2020

@googlebot
Copy link

googlebot commented Apr 26, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@shubhampatil17 shubhampatil17 force-pushed the PLUGIN-137-es-7.5.2-upgrade branch from 69d0c97 to 609f45c Compare April 26, 2020 14:51
@googlebot
Copy link

googlebot commented Apr 26, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@shubhampatil17
Copy link
Contributor Author

shubhampatil17 commented Apr 26, 2020

@googlebot I fixed it.

chtyim
chtyim reviewed Jun 27, 2020
View reviewed changes
Copy link
Contributor

@chtyim chtyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, rest LGTM

@shubhampatil17 shubhampatil17 changed the base branch from release/1.9 to develop June 28, 2020 00:10
@shubhampatil17 shubhampatil17 force-pushed the PLUGIN-137-es-7.5.2-upgrade branch 2 times, most recently from 58fc289 to 86b8517 Compare June 28, 2020 00:48
chtyim
chtyim reviewed Jun 28, 2020
View reviewed changes
Copy link
Contributor

@chtyim chtyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment left.

@shubhampatil17 shubhampatil17 force-pushed the PLUGIN-137-es-7.5.2-upgrade branch from 86b8517 to 2e11791 Compare June 28, 2020 18:54
@chtyim chtyim merged commit cd78be4 into data-integrations:develop Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chtyim chtyim chtyim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shubhampatil17 @googlebot @chtyim