(CDAP-17611) Added OAuth function support #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chtyim
force-pushed
the
feature/CDAP-17611-oauth
branch
2 times, most recently
from
dd4e48d to
ce33c0f
Compare
CuriousVini
approved these changes
Feb 17, 2021
tivv
approved these changes
Feb 17, 2021
| OAuthInfo oAuthInfo = config.getOAuthInfo(); | ||
| if (oAuthInfo != null) { | ||
| configBuilder.put(SalesforceConstants.CONFIG_OAUTH_TOKEN, oAuthInfo.getAccessToken()); | ||
| configBuilder.put(SalesforceConstants.CONFIG_OAUTH_INSTANCE_URL, oAuthInfo.getInstanceURL()); |
Contributor
There was a problem hiding this comment.
nit: use same style (chained or not of builder calls in both if and else
chtyim
force-pushed
the
feature/CDAP-17611-oauth
branch
from
ce33c0f to
b5c8108
Compare
supriyapatil-google
approved these changes
Feb 17, 2021
| @Description("OAuth information for connecting to Salesforce. " + | ||
| "It is expected to be an json string containing two properties, \"accessToken\" and \"instanceURL\", " + | ||
| "which carry the OAuth access token and the URL to connect to respectively. " + | ||
| "Use the ${oauth(provider, credentialId)} macro function for getting acquiring OAuth information dynamically. ") |
| /** | ||
| * Class to carry OAuth information returned by the {@code ${oauth}} macro function. | ||
| */ | ||
| public class OAuthInfo { |
| .put(SalesforceConstants.CONFIG_CONSUMER_KEY, config.getConsumerKey()) | ||
| .put(SalesforceConstants.CONFIG_CONSUMER_SECRET, config.getConsumerSecret()) | ||
| .put(SalesforceConstants.CONFIG_LOGIN_URL, config.getLoginUrl()) | ||
| .put(SalesforceSinkConstants.CONFIG_SOBJECT, config.getSObject()) |
Contributor
Author
There was a problem hiding this comment.
I think SOJBECT stands for the Salesforce object.
chtyim
force-pushed
the
feature/CDAP-17611-oauth
branch
from
b5c8108 to
7cf36f9
Compare
chtyim
force-pushed
the
feature/CDAP-17611-oauth
branch
from
7cf36f9 to
7769c1e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.