Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

Conversation

@PandiyanA
Copy link
Contributor

Bumped up the versions for CDAP and Hadoop to latest.

dli357
dli357 previously approved these changes Dec 8, 2022
Copy link
Contributor

@dli357 dli357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops didn't mean to approve; I think there was some offline discussion that this may require a fix for the unit tests before we can bump the hadoop version.

@dli357 dli357 self-requested a review December 8, 2022 09:28
@dli357 dli357 dismissed their stale review December 8, 2022 09:29

Unintentional approval

pom.xml Outdated
<hadoop.version>2.8.0</hadoop.version>
<cdap.version>6.8.0</cdap.version>
<hadoop.version>2.10.2</hadoop.version>
<hydrator.version>2.3.0-SNAPSHOT</hydrator.version>
Copy link
Contributor

@dli357 dli357 Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump hydrator plugins version to 2.10.0 as it depends on CDAP. Otherwise LGTM, thanks!

@feefs-google
Copy link
Contributor

Unit tests are failing because of dependency on cdap-explore. Since we're planning to remove it, let's leave this PR open until then.

@feefs-google
Copy link
Contributor

feefs-google commented Dec 16, 2022

After removing cdap-explore and bumping hydrator plugins to 2.10.2, unit tests that don't require credentials are passing, squashing and merging.

@feefs-google feefs-google merged commit 99ee098 into develop Dec 16, 2022
@feefs-google feefs-google deleted the vulnfix branch December 16, 2022 22:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants