Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

Conversation

@dgrinenko
Copy link
Contributor

@dgrinenko dgrinenko commented Oct 23, 2019

Jira: https://issues.cask.co/browse/PLUGIN-77
Wiki: https://wiki.cask.co/display/CE/SendGrid

In scope of this PR:

  • added source plugin

- pom.xml
- object definitions
- icons
- widget
- *.xml
@dgrinenko
Copy link
Contributor Author

@albertshau, @CuriousVini, @mikkin could you please review this PR?

@dgrinenko dgrinenko force-pushed the CDAP-15887 branch 5 times, most recently from e61ff61 to a8ee900 Compare October 26, 2019 23:02
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@dgrinenko dgrinenko changed the title SendGrid (SaaS source) (BatchSource/ MultiObject BatchSource) SendGrid (SaaS source) (BatchSource/ MultiObject BatchSource/ BatchSink) Nov 1, 2019
@mikkin mikkin changed the base branch from develop to wip_develop May 26, 2020 15:41
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mikkin mikkin merged commit 7cd1f80 into data-integrations:wip_develop May 27, 2020
shiva-cirus pushed a commit to shiva-cirus/sendgrid that referenced this pull request Aug 7, 2020
…nk) (data-integrations#2)

Co-authored-by: Mikkin Patel <mikkin@google.com>
Fixed an issue with macros not working
Added missing javadocs
Changed copyright to 2020
Modified to implement PR comments
Added TODO in code and JIRA ticket ID
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants