Skip to content

[PLUGIN-1809] Fix added to override schema #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[PLUGIN-1809] Fix added to override schema #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/io/cdap/plugin/snowflake/source/batch/SnowflakeBatchSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ public void prepareRun(BatchSourceContext context) {
@Override
public void initialize(BatchRuntimeContext context) throws Exception {
super.initialize(context);
SnowflakeSourceAccessor snowflakeAccessor = new SnowflakeSourceAccessor(config);
Schema schema = SchemaHelper.getSchema(snowflakeAccessor, config.getImportQuery());
Schema schema = SchemaHelper.getSchema(config, context.getFailureCollector());
this.transformer = new SnowflakeMapToRecordTransformer(schema);
}

Expand Down
17 changes: 17 additions & 0 deletions src/test/java/io/cdap/plugin/snowflake/common/util/SchemaHelperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,4 +184,21 @@ public void testGetSchemaWhenMacroIsEnabledSchemaIsNull() {
Assert.assertNull(actual);

}

@Test
public void testGetSchemaManuallyUpdatedTheSchema() {
Schema expected = Schema.recordOf("test",
Schema.Field.of("test_field", Schema.nullableOf(Schema.of(Schema.Type.LONG)))
);

SnowflakeBatchSourceConfig mockConfig = Mockito.mock(SnowflakeBatchSourceConfig.class);
Mockito.when(mockConfig.canConnect()).thenReturn(false);
Mockito.when(mockConfig.getSchema()).thenReturn(expected.toString());

MockFailureCollector collector = new MockFailureCollector(MOCK_STAGE);
Schema actual = SchemaHelper.getSchema(mockConfig, collector);

Assert.assertTrue(collector.getValidationFailures().isEmpty());
Assert.assertEquals(expected, actual);
}
}