DBP-68: login page needs to login to Google twice #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pan93412
commented
Sep 29, 2025
pan93412
commented
- refactor: prevent using middleware to improve static route
- fix(auth): Set the cookie's SameSite policy to "lax"
- refactor: reduce dynamic routes
Safari's SameSite policy applies throughout the entire session. This means that when we redirect to Google, then back to the callback, and finally to the homepage, the last redirect does not meet the strict SameSite requirements. As a result, the user must log in again. According to https://datatracker.ietf.org/doc/html/draft-ietf-oauth-browser-based-apps#section-6.1.3.3.1, SameSite can be set to Lax.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the authentication system to fix the Google login issue by moving from middleware-based authentication to component-based protection and adjusting cookie settings.
- Removes Next.js middleware for authentication and replaces it with React Server Components
- Changes cookie SameSite policy from "strict" to "lax" to improve OAuth flow compatibility
- Refactors login form components into separate modules for better maintainability
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| middleware.ts | Completely removes middleware-based authentication |
| lib/auth.ts | Updates cookie SameSite policy from "strict" to "lax" |
| providers/use-protected-route.tsx | Adds new server component for route protection |
| providers/use-apollo.rsc.tsx | Creates authorized Apollo wrapper component |
| next.config.ts | Adds authInterrupts configuration option |
| components/login-form/ | Refactors login form into separate alert components |
| app/ | Updates page components to use new authentication pattern |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.