-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade dependencies (2025/11/30) #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughA visibility scoping feature is added to questions in the GraphQL schema, enabling per-question visibility control through scope values with comprehensive filtering predicates. Runtime and development dependencies are upgraded to newer versions, including new Radix UI component libraries and framework updates. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
57-58: Inconsistent version pinning for PostHog packages.
posthog-jsis pinned exactly (1.298.1) whileposthog-nodeuses a caret range (^5.14.1). Consider aligning the pinning strategy for consistency — either pin both exactly for reproducibility or use caret ranges for both.- "posthog-js": "1.298.1", - "posthog-node": "^5.14.1", + "posthog-js": "^1.298.1", + "posthog-node": "^5.14.1",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
gql/graphql.ts(5 hunks)package.json(2 hunks)schema.graphql(5 hunks)
🔇 Additional comments (4)
schema.graphql (2)
74-78: LGTM - visibility scope field follows established patterns.The
visibleScopefield addition is consistent with the ent-generated schema conventions. The predicates inQuestionWhereInputand theclearVisibleScopeinUpdateQuestionInputfollow the same patterns used for other nullable string fields.
747-751: Clarify semantics: null vs empty string forvisibleScope.The documentation states "Empty means visible to everyone" but the field is nullable (
Stringwithout!). Consider clarifying whethernulland""(empty string) are treated equivalently, or if they have distinct meanings. This affects how consumers should query questions visible to everyone usingvisibleScopeIsNilvs checking for empty strings.gql/graphql.ts (1)
1-2: Generated file - changes are consistent with schema.This file is auto-generated by GraphQL Code Generator (indicated by
/* eslint-disable */). ThevisibleScopeadditions inCreateQuestionInput,Question,QuestionWhereInput, andUpdateQuestionInputcorrectly mirror the schema.graphql changes.package.json (1)
71-71: No compatibility concerns with Zod 4.x — current usage is compatible.The codebase uses only Zod patterns that are compatible with v4:
z.union(),z.object(),z.literal(),z.string().transform().describe(),z.number(), andsafeParse(). None of the v4 breaking changes (error customization API and ZodError internals) affect these patterns. The breaking changes mentioned in the original review regarding.default()short-circuit behavior,z.record()schema requirements, and stricter.int()validation do not apply to the current codebase.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.