Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@sundy-li
Copy link
Member

@sundy-li sundy-li commented Dec 7, 2024

  1. package management to uv
  2. update docker compose yaml to test ci feat: support cookie and temp table #83

@sundy-li
Copy link
Member Author

sundy-li commented Dec 7, 2024

        client.execute("select 1")
>       execute_query_id1 = client.connection.additional_headers["X-Databend-Query-Id"]
E       KeyError: 'X-Databend-Query-Id'

The key should be X-DATABEND-QUERY-ID, I don't know why the test are passed in previous version.

cc @hantmac @TCeason

Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@hantmac
Copy link
Member

hantmac commented Dec 9, 2024

        client.execute("select 1")
>       execute_query_id1 = client.connection.additional_headers["X-Databend-Query-Id"]
E       KeyError: 'X-Databend-Query-Id'

The key should be X-DATABEND-QUERY-ID, I don't know why the test are passed in previous version.

cc @hantmac @TCeason

@sundy-li Because the header key in http is Case-insensitive.

@hantmac hantmac merged commit dec102e into databendlabs:main Dec 9, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants