Skip to content

Conversation

@everpcpc
Copy link
Member

@everpcpc everpcpc commented Jun 16, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Fixes` for example configs.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jun 16, 2025
@everpcpc everpcpc requested review from BohuTANG and Copilot June 16, 2025 04:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the default port values in example configuration files to align with the current defaults.

  • Updated flight_api_address port in databend-query.toml
  • Revised admin_api_address and raft_api_port in databend-meta.toml

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/distribution/configs/databend-query.toml Updated flight_api_address to use port 9090
scripts/distribution/configs/databend-meta.toml Changed admin_api_address to port 28002 and raft_api_port to port 28004 with added deployment notes
Comments suppressed due to low confidence (3)

scripts/distribution/configs/databend-query.toml:9

  • Ensure that the updated flight_api_address port aligns with external dependencies and update related documentation accordingly.
flight_api_address = "0.0.0.0:9090"

scripts/distribution/configs/databend-meta.toml:4

  • Confirm that the new admin_api_address port is consistent with service expectations and update any external configuration guides as needed.
admin_api_address       = "0.0.0.0:28002"

scripts/distribution/configs/databend-meta.toml:21

  • Verify that the updated raft_api_port does not conflict with other cluster components and reflect this change in the deployment instructions.
raft_api_port = 28004

@BohuTANG BohuTANG merged commit 3c9e817 into databendlabs:main Jun 16, 2025
10 checks passed
@everpcpc everpcpc deleted the fix-config branch June 16, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants