refactor: compactor internal structure #18738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
- Add DropCallback to call a callback when being dropped. - Remove `CompactingData`, use `LeveledMap` directly. - Refine `WriterPermit` and `CompactorPermit` logging. - When building snapshot, it should acquire both the writer and compactor permits, because it needs to modify both the writable and the `immutable` data.
drmingdrmer
force-pushed
the
343-rm-compacting-data
branch
from
8103404 to
46c0591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: compactor internal structure
Add DropCallback to call a callback when being dropped.
Remove
CompactingData, useLeveledMapdirectly.Refine
WriterPermitandCompactorPermitlogging.When building snapshot, it should acquire both the writer and
compactor permits, because it needs to modify both the writable and
the
immutabledata.Tests
Type of change
Related Issues
This change is