Skip to content

Conversation

@forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Nov 14, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • While AggregateFunctionCombinatorNull previously excluded rows with null in any column,
    this PR separates count_distinct into a separate function that only excludes rows where all columns are null.
  • Improvements to sqllogictests' checking of ColumnType.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 14, 2025
@forsaken628 forsaken628 changed the title fix(query): count_distinct fix(query): count_istinct needs to handle nullable correctly Nov 17, 2025
@forsaken628 forsaken628 changed the title fix(query): count_istinct needs to handle nullable correctly fix(query): count_distinct needs to handle nullable correctly Nov 17, 2025
@forsaken628 forsaken628 marked this pull request as ready for review November 17, 2025 06:06
@forsaken628 forsaken628 requested a review from sundy-li November 17, 2025 06:06
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@forsaken628 forsaken628 merged commit b6bb253 into databendlabs:main Nov 17, 2025
87 checks passed
@forsaken628 forsaken628 deleted the distinct3 branch November 17, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants