Skip to content

Conversation

@KKould
Copy link
Member

@KKould KKould commented Nov 14, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • add: timestamp_tz::new from utc

  • fix: order by support datatype timestamp_tz

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - adjust the ts and offset encoding in timestamp_tz

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 14, 2025
@KKould KKould force-pushed the chore/timestamp_tz_storage branch from 1f52a97 to c90541b Compare November 14, 2025 16:40
@KKould KKould requested review from b41sh and youngsofun November 14, 2025 16:41
@KKould KKould self-assigned this Nov 14, 2025
@KKould KKould marked this pull request as ready for review November 17, 2025 02:08
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@KKould KKould force-pushed the chore/timestamp_tz_storage branch from c90541b to 21315e2 Compare November 17, 2025 04:08
@youngsofun youngsofun merged commit ff62551 into databendlabs:main Nov 18, 2025
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants