-
Notifications
You must be signed in to change notification settings - Fork 838
feat(query):masking policy support rbac #18982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
a4ffed7 to
970f6f3
Compare
fd3a0fe to
b4b21ad
Compare
drmingdrmer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drmingdrmer reviewed 8 of 43 files at r1, 2 of 3 files at r2, all commit messages.
Reviewable status: 10 of 43 files reviewed, 3 unresolved discussions
src/meta/app/src/data_mask/data_mask_id_to_name_ident.rs line 48 at r2 (raw file):
const PREFIX: &'static str = "__fd_datamask_id_to_name"; const TYPE: &'static str = "DataMaskIdToNameIdent"; const HAS_TENANT: bool = false;
add tenant to the key for all keys if possible in future. For better export/import support
src/meta/api/src/data_mask_api.rs line 54 at r2 (raw file):
&self, name_ident: &DataMaskNameIdent, ) -> Result<Option<u64>, MetaError>;
Using SeqV<_> would be better
src/meta/api/src/data_mask_api.rs line 60 at r2 (raw file):
tenant: &Tenant, policy_id: u64, ) -> Result<Option<String>, MetaError>;
Use SeqV
1c4f8b9 to
1813f42
Compare
1813f42 to
d92fbc7
Compare
drmingdrmer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drmingdrmer reviewed 8 of 43 files at r1, 5 of 11 files at r3, 1 of 2 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: 23 of 43 files reviewed, all discussions resolved
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
Type of change
This change is