refactor: move aggregation spill logic into partial aggregate #18999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
dqhl76
force-pushed
the
improve-aggregate-20
branch
from
546f54c to
6fcfefe
Compare
dqhl76
force-pushed
the
improve-aggregate-20
branch
from
6fcfefe to
cc31022
Compare
dqhl76
added
ci-benchmark
Contributor
Docker Image for PR
|
Contributor
dqhl76
added
ci-benchmark-cloud
Contributor
Docker Image for PR
|
Contributor
dqhl76
added
ci-benchmark-cloud
dqhl76
added
the
ci-benchmark-cloud
Contributor
Docker Image for PR
|
Contributor
Docker Image for PR
|
Contributor
Contributor
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
...query/service/src/pipelines/processors/transforms/aggregator/serde/transform_spill_reader.rs
Show resolved
Hide resolved
zhang2014
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
close: #18906
refactor: move aggregation spill logic into partial aggregate
Tests
Type of change
This change is