-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce message width #9
Conversation
Yep, sounds good to me. Here are the places I see locally that we're using
Do you know any others? |
return init_logger(name, level, stream, logfile, | ||
make_root, propagate, silent, devmode, | ||
verbosity, fmt, datefmt, plain_format, style) | ||
return init_logger(**logs_cli_args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better, thanks.
just crossed my mind -- would it be possible to just name it "V" in the help, but then duplicate that over to |
@nsheff tail of
I think this will spare us needing to change all the dependents. |
awesome, I forgot about |
logmuse/est.py
Outdated
"metavar": "V", | ||
"help": "Set logging level (integer from 0-5 or Python builtin)"}, | ||
"metavar": "V", "choices": [str(x) for x in range(0, 6)] + LEVEL_BY_VERBOSITY + ["WARNING"], | ||
"help": "Set logging level (0-5 or logging module level name)"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆 !
It would be nice if the logmuse options were very compact so they didn't clutter the help CLI output of a tool that uses logmuse. look at this:
In this PR I chagned the logdev and verbosity help messages to fit on one line, which is nice. However, because "VERBOSITY" is so long, it still takes up 2 lines regardless of size of the help message. See this question for a complete description of what I mean.
I propose: we change the
dest
forverbosity
to be shorter... justV
perhaps? that will solve this problem without requiring every tool that uses logmuse to have a custom help formatter.